Skip to content

Conversation

lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Aug 29, 2025

Dependencies CI Test: https://github.com/googleapis/sdk-platform-java/actions/runs/18327368470/job/52195017520

Changes

In order to keep the current Maven pom.xml files the same, we create a new format in the dependencies.txt file:
{GroupID}:{ArtifactID},{MavenPropertyID}={Version}. The GroupID, ArtifactID, and Version values are by renovate bot to determine there should be a dependency bump. The MavenPropertyID and Version values are used to build the maven test command.

The format may not look intuitive and can be changed in the future. Values/ Separators were chosen so that it doesn't have any weird edge cases/ impact in shell scripts (avoiding ';', '*', '|' characters)

Local Renovate Bot Invocation

Local invocation of renovate shows that it is able to match the versions:

{
     "depName": "com.fasterxml.jackson:jackson-bom",
     "currentValue": "2.19.2",
     "datasource": "maven",
     "replaceString": "com.fasterxml.jackson:jackson-bom=2.19.2\n",
     "updates": [
       {
         "bucket": "non-major",
         "newVersion": "2.20.0",
         "newValue": "2.20.0",
         "releaseTimestamp": "2025-08-28T22:48:03.000Z",
         "newVersionAgeInDays": 0,
         "newMajor": 2,
         "newMinor": 20,
         "newPatch": 0,
         "updateType": "minor",
         "isBreaking": false,
         "branchName": "renovate/com.fasterxml.jackson-jackson-bom-2.x"
       }
     ],
     ...
 ],
   "matchStrings": ["(?<depName>.*)=(?<currentValue>.*)\\n"],
   "datasourceTemplate": "maven",
   "packageFile": "dependencies.txt"
 }

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 29, 2025
Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 7, 2025
@lqiu96 lqiu96 force-pushed the renovate-bot-upper-bound-file branch from 5e8d7b3 to ba9bb67 Compare October 7, 2025 16:19
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Oct 7, 2025
Copy link

sonarqubecloud bot commented Oct 7, 2025

Copy link

sonarqubecloud bot commented Oct 7, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lqiu96 lqiu96 marked this pull request as ready for review October 7, 2025 22:05
@lqiu96 lqiu96 requested a review from blakeli0 October 7, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant